Skip to content

docs(android): fix stale NdkOptions import path in native-crashes.mdx - #47

Merged
krassx merged 1 commit into
bugsee:mainfrom
fishmanalex:fix/android-native-crashes-ndk-options-path
Sep 5, 2026
Merged

docs(android): fix stale NdkOptions import path in native-crashes.mdx#47
krassx merged 1 commit into
bugsee:mainfrom
fishmanalex:fix/android-native-crashes-ndk-options-path

Conversation

@fishmanalex

Copy link
Copy Markdown
Contributor

Summary

  • docs/sdk/android/issue-detection/native-crashes.mdx (prose and a code import) still points NdkOptions at com.bugsee.library.ndk.contracts.options.NdkOptions.
  • configuration/ndk.mdx — fixed in a previous round — now correctly documents the real path (com.bugsee.library.contracts.options.NdkOptions) and explicitly calls the old path a deprecated compatibility alias.
  • This page wasn't updated to match, so it re-taught the exact mistake that was already corrected elsewhere.

Changes

  • Updated the prose reference and the Java import line to the current path.

Test plan

  • npx cspell on the changed file — 0 issues
  • Confirmed no other stale ndk.contracts references remain in the file

🤖 Generated with Claude Code

https://claude.ai/code/session_01QnXDhVitCVmMNafPRvKUat

The prose and code import both pointed at the deprecated
com.bugsee.library.ndk.contracts.options.NdkOptions path.
configuration/ndk.mdx already documents the real path,
com.bugsee.library.contracts.options.NdkOptions, and explicitly calls
the old path a deprecated compatibility alias. This page wasn't
updated to match, so it re-taught the exact mistake that was already
corrected elsewhere.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@krassx

krassx commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

Confirmed against android/sdk. Both classes exist in the ndk module:

  • ndk/src/main/java/com/bugsee/library/contracts/options/NdkOptions.java — current
  • ndk/src/main/java/com/bugsee/library/ndk/contracts/options/NdkOptions.java@Deprecated, javadoc'd as "a source-compatibility alias that re-exports the same option keys… and will be removed in a future major version. Migrate to com.bugsee.library.contracts.options.NdkOptions."

There's even a regression test (ndk/src/test/java/.../NdkOptionsTest.java) guarding the relocation and the wire-value stability of the keys. Both the prose reference and the Java import are now on the surviving path. LGTM.

🤖 Generated with Claude Code

@krassx krassx left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validated against source (see review comment above). Approving.

@krassx
krassx merged commit f5d70d8 into bugsee:main Sep 5, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants