Skip to content

Let the OIDC redirect wait as long as the test, and give e2e a CPU #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bulbashenko merged 1 commit into from
Oct 27, 2026
Merged

Let the OIDC redirect wait as long as the test, and give e2e a CPU #29

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion deploy/staging/e2e.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,8 @@ spec:
- { name: E2E_KETO_WRITE, value: "http://keto:4467" }
- { name: E2E_MAILPIT, value: "http://mailpit:8025" }
resources:
requests: { cpu: 200m, memory: 512Mi }
# Chromium is CPU-bound; with 200m a TOTP test took 1.7 min here against 37 s in CI.
requests: { cpu: "1", memory: 512Mi }
limits: { memory: 1536Mi }
securityContext: *hardened
volumeMounts:
Expand Down
4 changes: 3 additions & 1 deletion e2e/tests/helpers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,8 +123,10 @@ export async function authorize(page: Page, clientId: string, scope: string, cha
})
await page.goto(`${AUTH}/oauth2/auth?${query}`)
// Hydra redirects to the app (a stand-in answers there); redirects cannot be intercepted, so wait for the URL.
// No timeout of its own: the wait spans the caller's sign-in, TOTP window included (up to 31 s), so only the test's
// timeout bounds it.
const callback = page
.waitForURL((url) => url.href.startsWith(APP_CALLBACK), { timeout: 45_000 })
.waitForURL((url) => url.href.startsWith(APP_CALLBACK), { timeout: 0 })
.then(() => new URL(page.url()))
return { callback }
}
Expand Down