Repository navigation
fix(typecheck): keep the Remotion video project out of the root tsc run - #276
Merged
Merged
Conversation
`video/field-notes-ai-agent-os` owns its package.json, package-lock and tsconfig (include: src, remotion.config.ts) and is deliberately not part of the Astro build. The root tsconfig never excluded it, so `tsc --noEmit` walked into it and reported 19 x TS2307 "Cannot find module 'remotion'" on any PR that triggers the test workflow, because those deps are only installed inside video/. The last src-touching PR predates the video commit, so the breakage stayed invisible until now. Excluding video/ (and dist/, node_modules/) restores `npm run typecheck` to clean without installing a second dependency tree in CI.
The type-check step is only trustworthy if a tsconfig change is actually exercised. tsconfig.json was missing from both path filters, so a PR that touched nothing else got no checks at all and could not satisfy the required status check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
npm run typecheckfails on any PR that triggers the test workflow:video/field-notes-ai-agent-osis a standalone Remotion project with its ownpackage.json,package-lock.jsonandtsconfig.json(include: ["src", "remotion.config.ts"]). CI runsnpm ciat the root only, soremotionis never installed, and the roottsc --noEmitwalks intovideo/**because that directory was never excluded.This is pre-existing: the video commit (
d5f247e) landed after the lastsrc/**PR, and the deploy workflow onmasteronly builds Astro, so nothing noticed.Change
One line in
tsconfig.json:video/stays type-checked by its own config when someone works in it; the site build is unaffected (it never imports fromvideo/, and the Docker build already excludes it).Verification
npm run typecheck→ 19 × TS2307, all undervideo/npm run typecheck→ clean (astro sync+tsc --noEmit)npm run build→ 44 pages