Repository navigation
feat(crypto): Add support for Ed25519 - #330
Merged
Merged
Conversation
Supports [sign, verify, importKey] Some tests are failing due to WPT tests targeting an old version of the spec. Does not implement the optional small order check, as it's optional and OpenSSL doesn't support it either.
VirtualTim
marked this pull request as ready for review
October 20, 2026 02:54
Contributor
Author
|
I found a few latent issues when investigating Ed25519 WPT tests failures. |
andreiltd
reviewed
Oct 20, 2026
andreiltd
reviewed
Oct 20, 2026
andreiltd
approved these changes
Oct 21, 2026
This was referenced Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Once in, I think this closes #123.
This change was strongly inspired by #277 (thanks @cupofjoakim).
Some tests are failing due to WPT tests targeting an old version of the spec.
Does not implement the optional small order check, as it's optional and OpenSSL doesn't support it either.
WPT Tests
Current state is 1103 / 1768.
8 tests fixed by #328.
10 tests fixed by #333.
240 tests fixed by #334.
Note that I split these into seperate PRs, as they're latent issues.
Some tests are failing due to lack of generateKey support.
Some tests are failing due to no small-order check.
I am not planning on adding support for either of those.