Repository navigation
feat: Allow resetting of engine at runtime - #337
Merged
Merged
Conversation
tschneidereit
approved these changes
Oct 21, 2026
tschneidereit
left a comment
tschneidereit
left a comment
Member
There was a problem hiding this comment.
I'm okay with landing this, but would advise doing a fairly thorough audit of the codebase before using this in production: the code has all been written with the assumption that it'll be run for exactly one request, so I wouldn't be particularly confident that there aren't latent bugs hidden somewhere that'd materialize under reuse.
andreiltd
approved these changes
Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our use of StarlingMonkey sometimes necessitates resetting the engine at runtime. This patch adds support.