Repository navigation
fix: Replace malformed UTF-8 and strip BOM in Response and Request text() and json() - #348
Merged
andreiltd merged 2 commits intoNov 2, 2026
Conversation
…xt() and json() Signed-off-by: araya <araya@araya.dev>
Signed-off-by: araya <araya@araya.dev>
andreiltd
reviewed
Nov 2, 2026
andreiltd
approved these changes
Nov 2, 2026
andreiltd
left a comment
andreiltd
left a comment
Member
There was a problem hiding this comment.
This looks good, thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently,
ResponseandRequest'stext()andjson()decode the body usingJS_NewStringCopyUTF8N. However, this deviates from the spec because malformed UTF-8 throws aTypeErrorinstead of being replaced with U+FFFD, and any leading UTF-8 BOM is preserved (causing things likejson()to fail on BOM-prefixed bodies).According to the Fetch spec, both methods should run UTF-8 decode on the body bytes (
text(), orjson()via parse JSON from bytes).This PR introduces a
utf8_decode()helper. It strips any leading UTF-8 BOM, then continues to useJS_NewStringCopyUTF8Nif the remaining bytes are valid UTF-8.Otherwise, it falls back to encoding_rs in replacement mode, matching the existing behavior of
Blob.text()andTextDecoder.