Skip to content

fix(metadata): replace existing OCI annotation sections - #2812

Open
subotac wants to merge 1 commit into
bytecodealliance:mainfrom
subotac:fix/replace-oci-metadata
Open

subotac wants to merge 1 commit into
bytecodealliance:mainfrom
subotac:fix/replace-oci-metadata

Conversation

@subotac

@subotac subotac commented Nov 8, 2026

Copy link
Copy Markdown

Fixes #2773.

Replace existing outer OCI annotation sections when setting new values instead of retaining both the old and new sections. Preserve nested metadata and Keep/Clear behavior.

Adds module/component regressions for all seven fields and repeated replacement. Validation: 28 package/doc tests, 11 metadata CLI tests, package Clippy with all features/targets, and workspace formatting pass.

@subotac
subotac requested a review from a team as a code owner November 8, 2026 16:01
@subotac
subotac requested review from fitzgen and removed request for a team November 8, 2026 16:01

@alexcrichton alexcrichton left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Would it be possible to model this as a CLI test in tests/cli/*.wat perhaps?

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

wasm-metadata: metadata add with a set OCI field keeps the old section and appends a duplicate

2 participants