Repository navigation
Conversation
adamrk
requested review from
cfallin and
rvolosatovs
and removed request for
a team
October 28, 2026 12:58
adamrk
force-pushed
the
abk/hyper-error-to-guest
branch
from
October 29, 2026 12:57
a7ac3aa to
e4f0989
Compare
The `run_http` test helper currently takes a channel and sends the uncollected http request down that channel for the caller to see. But only a few tests actually use that and it can otherwise be difficult because the request body many never actually be read and a guest program can be left hanging if it awaits that. This change hopefully makes `run_http` more intuitive by not taking the channel and in general reading the full request body. The new version `run_http_get_forwarded_request` can be used if the caller needs to see how the request was passed along and the new endpoint `p3-test-immediate-response` can be used when the test needs a response to be sent without the body being read.
Ensure that an error encountered when sending a request or response body is delivered to the associated `transmit` future when the body is coming from another host body which has been forwarded. Previously a guest which forwards a request or response would have no way to see if the request/response body was delivered without error. For example, if the original sender passed a body with incorrect content length or if it dropped the connection before completion, the guest would still receive `Ok(())` on the transmission future.
adamrk
force-pushed
the
abk/hyper-error-to-guest
branch
from
October 29, 2026 19:19
e4f0989 to
f742a25
Compare
adamrk
force-pushed
the
abk/hyper-error-to-guest
branch
from
October 29, 2026 19:31
f742a25 to
9dd3d9b
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure that an error encountered when sending a request or response body is delivered to the associated
transmitfuture when the body is coming from another host body which has been forwarded.Previously a guest which forwards a request or response would have no way to see if the request/response body was delivered without error. For example, if the original sender passed a body with incorrect content length or if it dropped the connection before completion, the guest would still receive
Ok(())on the transmission future.Depends on #15041 for testing.