Repository navigation
Add a make_inaccessible() to the cross-platform mmap abstraction. - #15082
Merged
alexcrichton merged 1 commit intoOct 30, 2026
Merged
Conversation
github-actions
Bot
added
the
wasmtime:api
erikrose
marked this pull request as ready for review
October 30, 2026 14:36
erikrose
changed the title
make_inaccessible() to the cross-platform-mmap abstraction.make_inaccessible() to the cross-platform mmap abstraction.
Factor out what was getting to be a lot of repetition while I'm at it.
erikrose
force-pushed
the
mmap-make-inaccessible
branch
from
October 30, 2026 16:30
d21f546 to
decd3c6
Compare
alexcrichton
approved these changes
Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I recently noticed we already have this mmap abstraction layer, so I might as well use it in the timing wheel in MMU interruption. It would bear fruit if we ever add more platform support. It bears fruit now in reducing the number of conditional compilations referencing
cfg(has_mmu_interruption). The overhead is negligible: there's only 1 extra syscall (vs. the raw mprotects I was using), and that's on page allocation, which is done only during warmup.Factor out what was getting to be a lot of repetition as well.