Repository navigation
Don't queue instantiation work on failure - #15093
Merged
Merged
Conversation
This commit fixes a minor issue where creating a component instance could report failure yet actually still queue up work within the event loop to perform instantiation. The fix is similar to bytecodealliance#14825 to ensure that work is never queued in the first place before failure is seen.
dicej
approved these changes
Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes a minor issue where creating a component instance could report failure yet actually still queue up work within the event loop to perform instantiation. The fix is similar to #14825 to ensure that work is never queued in the first place before failure is seen.