Repository navigation
Cranelift: opt: faster e-graph controlling type lookup - #15102
Merged
Merged
Conversation
Roughly cuts in half the compile-time cost from bytecodealliance#15052
github-actions
Bot
added
the
cranelift
alexcrichton
requested review from
fitzgen
and removed request for
alexcrichton
November 1, 2026 23:14
fitzgen
approved these changes
Nov 3, 2026
Member
|
Thanks! |
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
are-we-fast-yet identified a +0.68% instructions retired compilation regression on Sightglass from #15052.
This PR attempts to gain some cycles back by (1) inlining, and (2) using an existing
requires_typevar_operandhelper to avoid a more expensive lookup in the common case.Roughly cuts in half the compile-time cost from #15052 (geomean instructions retired from +0.65% to +0.39% relative to before #15052 on macOS aarch64).
CC @fitzgen