Repository navigation
Don't embed $OUT_DIR in proc macros - #15149
Merged
Merged
Conversation
This is the equivalent of bytecodealliance/wit-bindgen#1778 over here in the Wasmtime repository. In short by embedding `$OUT_DIR` in the proc macro it makes the build unreproducible and can reduce cache hits in larger build systems. Keep Wasmtime's debugging-only feature in parity with `wit-bindgen`'s feature here by shuffling around how this works. This additionally deletes the `include_generated_code_from_file` macro option as that's basically subsumed by `debug` which is a bit of a clearer name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the equivalent of bytecodealliance/wit-bindgen#1778 over here in the Wasmtime repository. In short by embedding
$OUT_DIRin the proc macro it makes the build unreproducible and can reduce cache hits in larger build systems. Keep Wasmtime's debugging-only feature in parity withwit-bindgen's feature here by shuffling around how this works.This additionally deletes the
include_generated_code_from_filemacro option as that's basically subsumed bydebugwhich is a bit of a clearer name.