Repository navigation
Conversation
The audit's #1 ranked opportunity (zero-syscall response write via the probed-only cwist_io_uring_sqpoll_send ring) was implemented on a branch and A/B-measured: the mechanism worked exactly (strace: sendmsg 1.00 -> 0.00 per request) but throughput halved and the tail worsened on both legs (c256 352k -> 178k RPS, P99.999 46.5 -> 77.0 ms; c400 386k -> 195k, 56.7 -> 77.6 ms; noise band RPS +-2-4%). Structural cause, same shape as the reverted multishot accept: the async path pays a full extra reactor round-trip per request (SEND CQE -> ring-fd wake -> reap -> re-arm) and ~65% more io_uring_enter calls. Not merged, no knob shipped. Mark ranked item 1 NEGATIVE with the numbers and the no-retry caveat so the headroom is not chased again blind; adjust item 3's reference to it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
What was measured (3 interleaved rounds per leg, cwist_bench, base-vs-base noise RPS ±2–4% / P99 ±8% / P99.999 ±25%)
The mechanism worked exactly as designed — strace shows
sendmsgdropping from 1.00 → 0.00 per request — but:Structural cause, same shape as the reverted multishot accept: the synchronous path re-arms the connection for reads immediately after
sendmsgreturns; the async path pays a full extra reactor round-trip per request (SEND CQE → ring-fd poll wake → reap → re-arm → next read wake) plus ~65% moreio_uring_entercalls. Not merged, no knob shipped; code discarded per the meaningful-change-only rule.The branch-implementation notes (per-worker ring after fork, CQ reader via reactor-registered ring fd, obuf lifetime gated on CQE,
-EPIPEsemantics, theIORING_SQ_NEED_WAKEUPidle-stall gotcha) are summarized in the doc entry for whoever considers the pipelining-across-the-gap architecture that might actually win.Test plan