Repository navigation
fix(ci): comment the empty except in redis_rate_limit_e2e.py - #456
Merged
Merged
Conversation
Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com> (cherry picked from commit ae19888)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings the code-quality fix merged to main in #454 (
ae198886c, "Potential fix for pull request finding 'Empty except'") to dev withgit cherry-pick -x, so the two branches stay identical here.The change is one comment line in
scripts/ci/redis_rate_limit_e2e.py, explaining whyProcessLookupErroris ignored when killing the test process group (the group already exited). There is no behaviour change. Before the pick, dev's copy of the file was identical to main's, and the file still compiles (py_compile).