Repository navigation
feat(stage): ask a person to confirm a lowered approval level - #138
Merged
Merged
Conversation
An agent with write access to the mirror could lower `approval` and then
stage. Stage compares the mirror's approval level only with this clone's
memory of the last level it saw (venfork/approval.json in the git common
dir, never pushed). It does not read venfork-config history. A lower
level needs a person to confirm at a terminal; an equal or higher level
is recorded silently. A missing memory (fresh clone) records the level
without a confirm. A memory that exists but cannot be read counts as
two-person.
--yes never answers this confirm, and with --json, --no-input or no TTY
stage stops with ApprovalError reason gate-weakened before the rebuild
(details.weakened is { from, to, unreadable? }). --dry-run reports it as
result.weakened and writes no memory. The guard is a convenience, not
protection: a fresh clone does not know an earlier level, so the docs
recommend branch protection on venfork-config.
cabljac
force-pushed
the
gate/04-weakening-guard
branch
from
October 19, 2026 17:26
4d5b253 to
86df6b5
Compare
cabljac
marked this pull request as ready for review
October 19, 2026 17:29
cabljac
added this pull request to stack #142
October 19, 2026 17:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An agent with write access to the mirror could lower
approvaland then stage. Stage now compares the mirror's level with this clone's memory of the last level it saw (venfork/approval.jsonin the git common dir, never pushed). A lower level needs a person at a terminal.--yesnever answers this confirm; with--json,--no-inputor no TTY, stage stops with reasongate-weakenedbefore the rebuild. An equal or higher level is recorded silently, so lower-then-raise is not flagged. A missing memory (a fresh clone) records the level without asking. A memory that exists but cannot be read counts astwo-person.The first version also scanned venfork-config history. Review showed filler commits, merges and hand-made commits all hid a lowering, so the user chose to drop the scan. The docs say plainly that a fresh clone does not know an earlier level, and recommend branch protection on venfork-config.
Tests, red first:
tests/integration/approval-guard.test.ts.bun run verifyexits 0. Counts: unit 1283 to 1283, integration 500 to 510.Not verified: e2e tiers and live GitHub. No test pins exit 130 when the confirm is cancelled.