Repository navigation
fix(stage): say the not-on-GitHub approval hint needs a terminal - #146
Merged
Merged
Conversation
On a gated mirror whose origin is not on GitHub, stage refused with a precondition hint to run `venfork stage approval off`. Lowering the level needs a person to confirm at a terminal, so a script or agent that followed the hint got `gate-weakened` on the next stage. The hint now says to run it at a terminal and confirm it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On a mirror with approval
reviewedortwo-personwhose origin is not on GitHub,venfork stagerefuses with apreconditionerror, because it cannot read the mirror PR. The hint said to runvenfork stage approval off. Lowering the level needs a person to confirm at a terminal, so a script or agent that followed the hint wroteoffwithout a confirm, and the next stage refused withgate-weakened. The hint led to a second refusal.The hint now says that a mirror not on GitHub cannot use the gate, and to run
venfork stage approval offat a terminal and confirm it. The gate behaviour does not change: a lowered level still needs a person at a terminal.Repro first: on the verify fixture (local bare origin),
stage approval two-person,stage --no-pr --yes,stage approval off,stage --no-pr --yesended ingate-weakened. With the fix the same drive at a terminal (vf_yes stage approval off) stages the branch. The new integration test intests/integration/approval.test.tspins the hint text and that following it stages.bun run verifypasses (1322 unit, 529 integration).Not verified: e2e tiers.