Repository navigation
chore: bump simple-git to v4 - #594
Merged
Merged
Conversation
fabioh8010
approved these changes
Oct 21, 2026
38 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
simple-git3.x (all versions up to 3.36.0) is affected by these advisories. They are fixed in 4.0.0/4.0.1:Because
@callstack/reassure-clidepends onsimple-git@^3.36.0, downstream projects can't resolve to a patched version, and Dependabot keeps flagging them.Reassure's own usage (
checkIsRepo()andrevparsewith fixed arguments) can't be exploited. The point of this PR is to let consumers clear the alerts.Changes
simple-gitto^4.0.2in@callstack/reassure-clisimpleGitimport, because v4 removed the default export (release notes). The named export also exists in v3.@callstack/reassure-cliWithout the import change, v4 makes
getGitBranch()/getGitCommitHash()throw. Theirtry/catchswallows the error, sobranchandcommitHashwould silently becomeundefinedin.perfoutput.Test plan
yarn validatepasseslib/commonjs/utils/git.jsagainstsimple-git@4.0.2:getGitBranch()andgetGitCommitHash()return the current branch and HEAD SHANo docs impact. No related issue.
– written by Claude on Ben's behalf