fix: re-read frontmatter before modal save to prevent overwriting concurrent task edits - #2291
Open
martin-forge wants to merge 2 commits into
Open
Conversation
…current task edits
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A background update to a task file can be undone when an already-open task edit window saves an unrelated change. For example, changing an estimate can restore an old scheduled date after a recurring task was completed elsewhere.
Solution
Read the latest frontmatter inside Obsidian's save callback and apply only the requested fields. Preserve background edits, completed occurrences and fields another writer removed. This changes the task update service only; it does not depend on the Calendar or security proposals.
Testing
npm run lintandnpm run build:testpass.