fix: stop startup when an existing settings file cannot be read - #2294
Open
martin-forge wants to merge 2 commits into
Open
fix: stop startup when an existing settings file cannot be read#2294martin-forge wants to merge 2 commits into
martin-forge wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When an existing settings file temporarily reads as null, TaskNotes blocks settings writes but can still start services using defaults. That can start background work with the wrong configuration.
Solution
Stop loading the plugin after the existing recovery reads fail. Leave the unreadable file untouched so it can be restored. A new install with no settings file still starts normally. Follow-up to #1591.
Testing
npm run lintandnpm run build:testpass.