fix(release-automation): drop the inert npm cache from pre-snapshot validation - #458
Merged
Merged
Conversation
…alidation Snapshot creation is slash-command driven, so the create-snapshot job always runs on an issue_comment event, whose Actions cache token is read-only. The step could never populate a cache and had no default-branch entry to restore from, so its only observable effect was a failed-save warning annotation on every release run. Also corrects the cache-scope comment in validation.yml: entries are scoped per git ref, not per repository.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
correction
What this PR does / why we need it:
#448 added
cache: npmto bothsetup-nodesteps that feed the sharednpm ci. The one invalidation.ymlworks as intended, but the one inrelease-automation-reusable.ymlcannot: snapshot creation is slash-command driven, socreate-snapshotalways runs on anissue_commentevent, and the Actions cache token for that event is read-only. Every snapshot run loggedcache write denied: token has no writable scopesand carried a failed-save warning annotation, while never populating a cache and having no default-branch entry to restore from. This drops that step's cache inputs and records why, so it does not get re-added.warning-level annotation from every release snapshot run.validation.yml's comment: entries are scoped per git ref, not per repository, so a pull request's first validation run still pays a cold install and only later pushes to the same PR hit the cache.Which issue(s) this PR fixes:
No separate issue — follows up #448.
Special notes for reviewers:
Measured after #448 merged:
regression/*branches (12 on ReleaseTest, 6 on CommonalitiesTest) against the caches its first firing had populated, and all 18 loggedCache restored from key— https://github.com/camaraproject/tooling/actions/runs/35378091248/create-snapshotround-trip from the RA canary showsCache mode: read, then the denied save — https://github.com/camaraproject/ReleaseTest/actions/runs/35374610286permissions:—push→ write,issues→ read,issue_comment→ read. Addingactions: writeis not the lever;validation.ymldoes not declare it either and writes fine.actionlintclean over all workflow files with the argument set fromtooling-ci.yml.Both call sites of
shared-actions/run-validationkeep the trimmednpm ci --ignore-scripts --no-audit --no-fund --prefer-offline;--prefer-offlinesimply no-ops where there is no cache.Changelog input
Additional documentation
This section can be blank.