fix: Remove top-level paths for code lists - #178
Open
daogrady wants to merge 6 commits into
Open
Conversation
daogrady
changed the title
daogrady
changed the title
daogrady
marked this pull request as ready for review
August 26, 2026 05:46
daogrady
enabled auto-merge (squash)
August 26, 2026 05:48
tim-sh
reviewed
Aug 26, 2026
tim-sh
left a comment
tim-sh
left a comment
Member
There was a problem hiding this comment.
Looks good – just to be sure, one question, plus could you double-check that top-level GET paths for value-help code lists (e.g. Currencies) still work?
| } | ||
| else if (!service["@protocol"]) { | ||
| protocols.push("rest"); //taking rest as default in case no relevant protocol is there | ||
| protocols.push(supportedProtocols.includes(protocol) ? protocol : "odata"); |
Member
There was a problem hiding this comment.
Is this change meant to be part of this PR?
Contributor
Author
There was a problem hiding this comment.
good catch, no, that slipped in from another PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #173
Specifically addresses behaviour reported in a comment, whereas the original issue was addressed in #177
Before fix:
routes for
OrderItemscode list exist on top levelAfter fix:
routes are no longer available on top level, but can be accessed via the navigation paths
POST /Orders({ID})/itemsetc.