feat(trigger-deployment-pipeline): run on the node24 runtime, implemented in TypeScript - #272
Merged
Merged
Conversation
joakimen
force-pushed
the
feat/upload-s3-artifact-typescript
branch
from
September 15, 2026 09:45
9ed80ed to
5efc16c
Compare
joakimen
force-pushed
the
feat/trigger-deployment-pipeline-typescript
branch
from
September 15, 2026 09:46
8dddc03 to
1ef2eb8
Compare
joakimen
force-pushed
the
feat/upload-s3-artifact-typescript
branch
from
September 15, 2026 10:12
5efc16c to
ea2b56b
Compare
joakimen
force-pushed
the
feat/trigger-deployment-pipeline-typescript
branch
from
September 15, 2026 10:13
1ef2eb8 to
098ad60
Compare
joakimen
force-pushed
the
feat/upload-s3-artifact-typescript
branch
from
September 15, 2026 10:26
ea2b56b to
115266d
Compare
joakimen
force-pushed
the
feat/trigger-deployment-pipeline-typescript
branch
from
September 15, 2026 10:27
098ad60 to
cabd933
Compare
joakimen
force-pushed
the
feat/upload-s3-artifact-typescript
branch
2 times, most recently
from
September 15, 2026 10:43
142601d to
178538b
Compare
joakimen
force-pushed
the
feat/trigger-deployment-pipeline-typescript
branch
from
September 15, 2026 10:44
cabd933 to
d3751b0
Compare
Base automatically changed from
feat/upload-s3-artifact-typescript
to
master
September 15, 2026 11:18
…nted in TypeScript Writes the trigger file and pipeline variables with the AWS SDK and reads the run's start time with fetch, replacing the aws CLI, curl and jq. The trigger file is a contract with a deployed notification handler, so its shape is tested; building it as JSON also means a quote in a commit author's name no longer produces an invalid file. Uploads stay sequential. A pipeline starts when its trigger lands, so its metadata has to be there first. A pipelines input that is only whitespace is refused, where it used to name no pipeline, trigger nothing and report success. An unknown trigger-type is refused too, where it used to start a pipeline that had nothing to deploy. Inputs, the S3 layout, the parameter namespace and the trigger file's fields are unchanged.
joakimen
force-pushed
the
feat/trigger-deployment-pipeline-typescript
branch
from
September 15, 2026 12:22
d3751b0 to
55e1d6f
Compare
|
🎉 This PR is included in version 1.17.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the action to the
node24runtime. Writes the trigger file and pipeline variables with the AWS SDK and reads the run's start time withfetch, replacing theawsCLI,curlandjq.Unit tests now cover input parsing, the trigger file's shape and the S3 layout.
Behaviour
The trigger file is built as JSON rather than a heredoc, so a quote in a commit author's name no longer produces an invalid file.
An unknown
trigger-typeis now refused rather than starting pipelines with nothing to deploy.Stacked on #267, which adds the shared S3 module this uses.