Repository navigation
feat(contract): timeout_minutes, written outside config_hash - #92
Merged
Merged
Conversation
A node may declare timeout_minutes, an integer from 1 to 10,080. The loader refuses any other value, naming the node and the key. build_wire_contract writes the key onto the wire entry after the hash parts are computed, and canonical_entry leaves it out of the config_hash basis, so changing it alone changes none of the four hashes. A node that declares none has the wire entry it always had. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TchTVKaApWVophKNwtVHcT Signed-off-by: Simone Carolini <simonecarolini.sc@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
timeout_minutes(integer, 1 to 10,080;booland other types are refused). The loader names the node and the key in its error.build_wire_contractwrites the key onto the wire entry afterhash_parts, so it is the one wire key outsideconfig_hash; changing it alone is not a code change. A node that declares none keeps its exact wire entry.hashing.canonical_entrydrops the key, soconfig_hashrecomputed from a finished wire entry still matches.docs/boundary-contract.md, thehashing.pydocstring, the README and the CHANGELOG ([Unreleased]). No version bump here; the release commit bumps runtime, engine-contract and the postgres adapter.Testing
Full suite (684 passed, integration and image tests deselected), ruff and all five mypy runs clean.
🤖 Generated with Claude Code
https://claude.ai/code/session_01TchTVKaApWVophKNwtVHcT