fix: remove tdakkota/asciicheck from go.mod - #6
Conversation
The asciicheck package was renamed from github.com/tdakkota/asciicheck to github.com/golangci/asciicheck. Having both paths in the go workspace causes a fatal 'used for two different module paths' error in go generate. The package is not imported by any Go code in this module — it was an indirect linter tooling dependency. Co-Authored-By: Kimchi <noreply@kimchi.dev>
Kimchi Code Review
Summary📊 Review Score: 92/100 (overall code quality — 0 lowest, 100 highest) 🧪 Tests: no — No test files were modified; the change is a dependency cleanup in 📝 Found 1 issue(s). See inline comments for details. What to expectKimchi will analyze the changes in this pull request and post:
The review typically completes within a few minutes. This comment will be updated once the review is ready. Interact with Kimchi
ConfigurationReviews are configured by your organization admin. Powered by Kimchi — AI-powered code review by CAST AI |
![kimchi-review[bot]](https://avatars.githubusercontent.com/in/3223788?s=60&v=4){kind=small}
There was a problem hiding this comment.
📊 Review Score: 92/100 (overall code quality — 0 lowest, 100 highest)
⏱️ Estimated effort to review: 1/5 (1 = trivial, 5 = very complex)
🧪 Tests: no — No test files were modified; the change is a dependency cleanup in go.mod.
📝 Found 1 issue(s). See inline comments for details.
1 participant
The asciicheck package was renamed from github.com/tdakkota/asciicheck to github.com/golangci/asciicheck. Having both paths in the go workspace causes a fatal 'used for two different module paths' error in go generate.
The package is not imported by any Go code in this module — it was an indirect linter tooling dependency.