fix(release): drop unsupported 'priority' from the smoke-test config - #131
Merged
Conversation
…st config The release workflow's post-build smoke test wrote a test-config.yaml with 'priority: 10' on a process, a field config.Process does not have (processes are ordered by depends_on). Strict config decoding correctly rejects it, so the binary refused to start and the Test Release Binaries job failed on every release (v3.0.0 carried the same stale line). The released binaries themselves are fine. Also remove the same stale field from the release-notes example config so it does not teach an invalid key.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release workflow's smoke test used
priority: 10on a process, whichconfig.Processdoesn't have — strict decoding rejects it, so "Test Release Binaries" failed on every release (including v3.1.0 just now; the released binaries are fine, only the downstream smoke test failed). Removes it from both the smoke-test config and the release-notes example. Verified the corrected config loads via check-config.