Repository navigation
chore(develop): sync master - #1110
Merged
Merged
Conversation
… suites Daily and manual full runs are not merge gates, so their failures could go unnoticed. Report full validation keeps one issue per long-lived branch open while full CI fails and closes it once a full run passes. Releases could also merge after only change-based checks. A merge group that changes the release manifest now runs full validation, and Rust Test & NAPI Build requires the external suite comparisons to pass for it.
Syncing master into develop carries the release manifest change too, which made the develop merge group run and wait for the external comparisons although it tags nothing. Pass the merge group base ref to the classifier and only mark master merge groups as releases.
ci-changes.mjs could skip product validation for a Release Please pull request, but ci.yml never set RELEASE_PLEASE_PR, and the release diff also bumps Cargo.toml and Cargo.lock. The release PR therefore ran every job on each master push (71 runs and about 3,600 job-minutes in two weeks). Set the flag for the repository's own release branch and accept its Cargo version bumps. The master merge group that cuts the release now runs full validation, so nothing merges without it.
CI checks out a single commit, so the release test could not find the parent of the latest release manifest change. Create the two commits it needs in a temporary repository instead.
Celox-Sync-Automation: true
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bring stable-trunk changes into the Veryl HEAD compatibility lane.
This PR is managed automatically through a dedicated synchronization branch so the develop merge queue never holds
masteritself as a pull request head. A conflict is actionable and must be resolved without replacing the Veryl HEAD dependency ondevelop.