Repository navigation
ci: preserve shared Rust caches and avoid unnecessary product builds - #1324
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e9a79d71a3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| } | ||
|
|
||
| if (startsWithAny(path, ["scripts/"])) { | ||
| if (path === ".mergify.yml" || startsWithAny(path, ["scripts/"])) { |
There was a problem hiding this comment.
When a PR changes only .github/workflows/rust-cache.yml, this condition does not set scripts, and the later generic .github/workflows/ branch treats the file as neutral. Consequently the lint job skips node --test scripts/*.test.mjs, so the newly added test that reads this workflow never checks the very edits it is meant to protect; a mismatch in the job ID, features, nextest version, or cache policy can therefore merge without validation. Include this workflow in the script-validation classification (or otherwise schedule its focused test).
AGENTS.md reference: AGENTS.md:L14-L16
Useful? React with 👍 / 👎.
tignear
added
the
merge-ready
Merge Queue Status
This pull request spent 1 hour 1 minute 14 seconds in the queue, including 31 minutes 42 seconds running CI. Required conditions to merge
|
1 participant
Problem and change
Rust Tests job 116692374518 spent 17m36s compiling before starting 13,562 tests, with no restored cache. During investigation, the repository used about 10 GB of caches, mostly isolated PR merge refs, while master had no Rust cache. A
.mergify.yml-only change also fell through the unknown-path classifier and unnecessarily selected every product job..mergify.ymlas script validation. Mixed Rust changes and unknown paths retain broad coverage.cargo nextest listwithout running tests; an exact hit skips compilation. Daily master CI populates the other job caches.Test coverage and required checks are unchanged. Workspace binaries are not added to the cache. Initial warmup and new toolchains still require compilation; runtime improvement needs measurement after the shared cache is populated. The change reaches develop through the existing master-to-develop sync.
Validation
ubuntu-26.04-armlabel diagnostic.list --workspace --locked --message-format json; diff checks passed.