Repository navigation
chore(deps): coordinate Python and cocotb updates - #595
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 69a956ecc1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| run: updatecli pipeline apply --config .updatecli/updatecli.d | ||
| env: | ||
| UPDATECLI_GITHUB_ACTOR: ${{ github.actor }} | ||
| UPDATECLI_GITHUB_TOKEN: ${{ github.token }} |
There was a problem hiding this comment.
When a scheduled or manually dispatched apply creates its branch and pull request with ${{ github.token }}, neither the resulting push nor pull_request event starts another workflow: GitHub documents that events caused by GITHUB_TOKEN, except explicit dispatch events, do not create workflow runs (automatic token authentication). Consequently, the generated dependency PR never receives the regular ci.yml compatibility check described as its final validation; use a GitHub App/PAT credential or explicitly dispatch a workflow that supports workflow_dispatch.
Useful? React with 👍 / 👎.
| version-file: .updatecli-version | ||
|
|
||
| - name: Preview update policy | ||
| run: updatecli pipeline diff --config .updatecli/updatecli.d |
There was a problem hiding this comment.
When a pull request changes the selector or its test cases, this workflow only runs updatecli pipeline diff, while the regular CI workflow invokes only the Node test suite under scripts/; no workflow runs .updatecli/tests/test_latest_compatible_python.py. The preview exercises the current live-data path but not the filtering and failure cases covered by these tests, so those tests can regress or fail while every required check remains green; add the unittest discovery command as a workflow step.
Useful? React with 👍 / 👎.
| - ".github/workflows/updatecli.yml" | ||
| - ".updatecli-version" | ||
| - ".updatecli/**" | ||
| - "renovate.json" |
There was a problem hiding this comment.
When a pull request edits .github/workflows/ci.yml, this path filter does not run the Updatecli preview even though both file targets rely on exact regular-expression matches in that workflow. A reformat such as changing the quote style around python-version or restructuring the cocotb install command can therefore merge without validating the policy and leave the next scheduled apply unable to update either pin; include .github/workflows/ci.yml in the trigger paths.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0879d86824
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
Codex Review: Didn't find any major issues. Keep them coming! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
1 participant
Summary
Why
Updating the
actions/setup-pythonruntime independently can select a Python release before cocotb publishes a compatible Linux x86-64 wheel. Grouping independent Renovate updates does not resolve that ordering problem.The Updatecli policy first resolves the latest stable cocotb release, then intersects its CPython manylinux x86-64 wheel tags with stable Linux x64 releases from
actions/python-versions. This permits Python to advance automatically when cocotb support is actually available, without a permanent version cap.With the current upstream metadata, cocotb 2.0.1 selects Python 3.13.
Validation
updatecli --experimental manifest validate --strictactions/python-versionsmetadatapython3 -m unittest discover -s .updatecli/tests -vgit diff --check