build(devcontainer): migrate onto the shared devbase Feature - #342
Merged
Conversation
The zsh prompt configuration, commitizen setup, pnpm bootstrap, shell history symlink, the ~/.gitconfig symlink and the common CLI packages now come from the devbase Feature and the host mounts, which is most of what post-create.sh used to do. Python moves out of the language image and into the python Feature at latest — what the python:3 image resolved to. The compose stack ran a single service and needed no backing services, so the frame is now the single-container shape. The workspace lands at the same /usr/share/rtldev-middleware-python-sdk the compose volume mounted it at. post-create.sh keeps only the part devbase does not cover: pip, pip-tools, the requirements.txt compile and the editable install. The globally installed gulp-cli is dropped with it — this repository has no gulp tasks. RSRMID-3019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of RSRMID-3019 — the last six repositories still carrying a hand-maintained devcontainer move onto the shared
devbaseFeature, as php-sdk did in RSRMID-2976.What moves out
The zsh prompt configuration, the commitizen setup, the pnpm bootstrap, the shell-history symlink, the
~/.gitconfigsymlink and the common CLI packages aredevbase's job and the host mounts' job now — which is most of whatpost-create.shdid. Node LTS, the GitHub CLI and the Claude Code CLI aredevbase's own dependencies, so this frame declares none of them.Python moves out of the language image and into the
pythonFeature atlatest, which is what thepython:3image resolved to.What stays
post-create.shkeeps only the partdevbasedoes not cover: pip, pip-tools, therequirements.txtcompile frompyproject.toml, and the editable install ofcentralnicreseller. The globally installedgulp-cliis dropped with it — this repository has no gulp tasks.ms-python.pythonis added to the extension list, which the old frame did not have at all (it carried an Intelephense/Apache set inherited from a PHP repository).Compose → single container
The stack ran a single service with no backing services, so the frame is now the single-container shape. The workspace lands at the same
/usr/share/rtldev-middleware-python-sdkthe compose volume mounted it at.Verification
Not rebuilt yet — no Docker daemon in the workspace this was prepared from. Before merging, rebuild and check: the prompt renders,
devbase-env-inforeports Python and Node, the pip install completes,cz --versionworks, andgit pushauthenticates throughgh. The first rebuild also writes adevcontainer-lock.json, which should then be committed.🤖 Generated with Claude Code