Repository navigation
ci: run the e2e suite on pull requests that are ready for review - #51
Merged
Merged
Conversation
wp-env now starts in the background while the e2e dependencies and Chrome install, and a later step waits for it and prints its log. WordPress core comes from the release zip instead of a git clone.
The e2e workflow keyed its npm cache on both lockfiles, a key nothing on main saves, so every branch run missed it. Keying on the root lockfile, as ci.yml does, reuses the cache ci.yml saves on main.
This reverts commit 95769a9.
Skips drafts, fork pull requests (no secrets) and changes outside the plugin, its build inputs and the suite. A small job on main saves the npm cache under the e2e key, so pull request runs restore it instead of saving their own.
✅ WordPress Plugin Check Report
📊 ReportAll checks passed! No errors or warnings found. 🤖 Generated by WordPress Plugin Check Action • Learn more about Plugin Check |
domiebett
marked this pull request as ready for review
October 15, 2026 15:54
jcalabek
approved these changes
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Runs the e2e suite on pull requests that are ready for review, so it no longer needs a manual dispatch.
What changed
e2e-tests.ymlalso runs onpull_request(opened, synchronize, reopened, ready_for_review). The e2e job skips drafts, so marking a draft ready starts a run.pull_request, notpull_request_target, so code from a fork never runs with the API key.ceros.php,includes/,src/,public/), its build inputs (package.json,package-lock.json,.wp-env.json), the suite and this workflow.warm-cachejob runs on pushes to main that change a lockfile or this workflow. It installs both packages under the e2e cache key, without WordPress, a browser or the secret. Branches can only restore caches saved on main, and main never ran e2e, so every pull request missed on its first run and saved its own copy.E2E_CEROS_ENVfalls back tolatestwhen there is no dispatch input, and the workflow is renamed from "E2E (manual)" to "E2E".Running