Repository navigation
Housekeeping: CodeQL #176, ASVS 2.3.4, TS4 closed, an image 1 GB smaller, a timestamp flake - #66
Merged
Merged
Conversation
…ge's size Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…age 1 GB smaller HK1: reviewing an outside service shows a fixed sentence, never an exception's text; the module raises its own OutsideServiceError (CodeQL py/stack-trace-exposure, alert #176). HK2: ASVS 2.3.4 is Met: the three Postgres tests that prove the locks (two decisions at once, a check presented twice, two outbox runs) carry its mark. The crosswalk no longer says gaps are planned for 1.24 and 1.25. HK3: TEST_SPEED_PLAN.md TS4 closed with today's times. HK5: the image's last step ran chown -R over /venv and /app, storing every file twice. Ownership is now set by COPY --chown, and the image is 1.39 GB instead of 2.41 GB, with the same owners. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…a timestamp
Every page's head carries Unix timestamps (base.html's session-expiry meta tags). Two tests
asserted a short number was absent from the whole page, so they failed whenever the clock's
digits contained it ("4001" in content="1794001071"). tests/items.py gains shows_number, which
matches a number only where it stands alone.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
plans/HOUSEKEEPING_PLAN.md: small things left after every plan's buildable work shipped, with the product owner's decisions HK-D1 to HK-D4.py/stack-trace-exposure). Reviewing an outside service under Settings caught aValueErrorand showed its text to the person. Today that text is only OpenClear's own sentence, but anything deeper raisingValueErrorlater would have shown its own message. The module now raisesOutsideServiceError, and the router shows a fixed sentence. The alert should close when CodeQL scansmain.asvs("2.3.4"): two decisions at once, a check presented twice, two outbox runs at once. The crosswalk no longer says the remaining gaps are "planned for 1.24 and 1.25".TEST_SPEED_PLAN.mdTS4 is closed with today's times. CI takes about 5 minutes, which meets its target. The local Postgres suite takes 7 minutes; the suite has grown 13% since its 4-minute target was set.chown -R openclear:openclear /data /app /venv, which copied every file under/venvand/appinto a layer of its own, so the 738 MB venv was stored twice.COPY --chown. The last step changes only/dataand/appthemselves./appand/dataare writable.chownout of the final stage.<head>carries Unix timestamps (the session-expiry meta tags). Two tests asserted a short number ("4001", the test bank's house account "0001") appeared nowhere on the page, so they failed whenever the clock's digits contained it.tests/items.pygainsshows_number, which matches a number only where it stands alone. No other test makes that assertion.HK4 (branches) changed nothing in the repository; what was done locally, and what waits, is in the plan's log.
Checks
CHANGELOG.mdhas entries under "Unreleased": the image size and the ASVS count.docs/compliance/asvs.mdregenerated.Security (OWASP WSTG)
openclearuser, with the same ownership on every file.🤖 Generated with Claude Code