Repository navigation
tarfs: reference package file contents by digest - #2593
Closed
kevinmdavis wants to merge 1 commit into
Closed
kevinmdavis wants to merge 1 commit into
kevinmdavis wants to merge 1 commit into
Conversation
Record SHA-256 content digests while indexing expanded APKs and use them to reference package file contents from tarfs. This separates the tree from archive paths so more metadata-only operations can work without reading unmodified package data. Preserve the existing PackageContents and WriteHeaderer contracts, including calls through filesystem wrappers. Sources without digest support retain lazy reads by name and APK checksum comparisons, while digest-aware sources use the content store. Share mutable buffers across file handles and cover both backing paths with regression tests. Validate incomplete entries before changing the tree and reuse the archive hashing buffer to avoid per-entry allocations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Record SHA-256 content digests while indexing expanded APKs and use them to reference package file contents from tarfs. This separates the tree from archive paths so more metadata-only operations can work without reading unmodified package data.
Preserve the existing PackageContents and WriteHeaderer contracts, including calls through filesystem wrappers. Sources without digest support retain lazy reads by name and APK checksum comparisons, while digest-aware sources use the content store.
Share mutable buffers across file handles and cover both backing paths with regression tests. Validate incomplete entries before changing the tree and reuse the archive hashing buffer to avoid per-entry allocations.