Repository navigation
Conversation
Signed-off-by: Nghia Tran <tcnghia@gmail.com>
Contributor
Author
|
Closing as a duplicate of #2602, which makes the same key refresh. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestLock/apko-discovernow fails on every apko PR, including #2600, which only changes APK cache files. Since #2322, the golden lock has embedded keyring content fetched live from apk.cgr.dev. The server now returns HTTP 404 for the embeddede3fb44…key and serves717fef…instead. This is the same refresh as #2203 and #2350.This PR addresses that by:
e3fb44…key frominternal/cli/testdata/apko-discover.lock.json.717fef…key from the test's ownLockCmdoutput. The diff is five lines added and five removed, with no other changes.Evidence
I temporarily made
TestLockwrite its output over the golden file, rango test -run '^TestLock$/^apko-discover$' ./internal/cli/, then reverted the test change. At commitd849c4a,go test -count=1 -run '^TestLock$' ./internal/cli/passes. The embedded717fef…content has the same SHA-256 (fc774d8f…) as the key fetched withcurl -sfrom apk.cgr.dev; the old key URL returns HTTP 404.Note to reviewers: please feel free to independently validate our results.