Repository navigation
Update third-party rules as of 2026-10-27 - #1781
Merged
Merged
Conversation
egibs
approved these changes
Oct 27, 2026
egibs
enabled auto-merge (squash)
October 27, 2026 19:53
GuardDog's rules now compare an "ecosystem" external, which pkg/compile defines as an empty global. pkg/report's test helper built its own compiler with a hand-copied globals map, so it failed to compile the updated rules (E009 unknown identifier) and blocked the rule update. Export compile.NewCompiler and use it in the test helpers that compile rules, so tests build rules with the same options and globals as production and cannot drift when a global is added.
egibs
approved these changes
Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
2026-10-27 third-party rule update for malcontent.