omit null xray request slices - #71
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
FilterVulnBodyandFilterReportrequest JSON instead of sendingnullxprocess_idfield and CLI flag to vulnerability filteringPostVulnFilter --body, preventingxprocess_idsfrom being silently ignoredtags: []Why
X-Ray's Django REST Framework serializers accept omitted optional list filters but reject explicit
null. The generated Go request models serialized nil slices asnull, causingPostVulnFilter,PostReportFilter, and related request paths to fail withINVALID_PAYLOAD.Impact
xprocess_idsinput now fails locally; callers should use singularxprocess_idRoot cause
The generated request models had inconsistent JSON tags and custom marshal structures for optional slices. The vulnerability model was also behind the current OpenAPI definition and omitted
xprocess_id.Checks
task testtask linttask buildgit diff --checkPostVulnFilterminimal body, populatedstatusslice,xprocess_id, and CLI flag pathsPostReportFilterminimal body and populatedstatusslice