Skip to content

e2e: choice-builder-pages "opens a macro's branch" can miss the Configure Log click under load #2220

Open

Description

@chhoumann

tests/e2e/choice-builder-pages.test.ts, test "opens a macro's branch and Choice step as pages over it, and back returns to the macro", failed once at line 165. It was a native run on Linux with Obsidian 1.14.4, at master e772433 plus #2219, with a host load average of about 57.

clickWhenStill found .macroBuilder [aria-label="Configure Log"] and clicked it. The page stack then stayed at ["Morning"] instead of ["Morning", "Log"]. The click comes right after leaveSettingsPage, while the macro page slides back in.

The spec passed 12 of 12 when rerun alone twice, and every caller spec passed in a full rerun of all seven (24 of 24 tests). One failure is not enough to confirm a cause.

Unconfirmed guess: under heavy load the slide-in animation can stall for the 100 ms between two samples. clickWhenStill then sees two equal positions and clicks mid-transition, before the row takes clicks.

Found while verifying #2219.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions