Repository navigation
chore(store): move the extension into extension/ so only it ships - #23
Merged
Merged
Conversation
The Raycast reviewer asked for the vaults, the scripts, ARCHITECTURE.md, and the dev sections of the README to stay out of raycast/extensions. ray publish copies its whole working directory and has no ignore file, so the extension now lives in extension/ and is published from there, the way the monorepo lays extensions out. The root README holds the dev notes, and the store README links ARCHITECTURE.md on GitHub.
The current-note cases need 2.32, and the vault's manifest still said 2.30.0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Raycast Store reviewer on raycast/extensions#31967 asked for two things: a README without the Development and Install sections and the badges, and an extension folder without the vaults, the scripts, ARCHITECTURE.md, and the
e2e:protocolnpm script.ray publishcopies its whole working directory into the monorepo and has no ignore file, so the extension now lives inextension/and is published from there, the same layout the monorepo uses. The root README holds the dev notes and points at the store README, which links ARCHITECTURE.md on GitHub. CI runs inextension/. The e2e script imports from there and the e2e vault now expects QuickAdd 2.32.1, which its current-note cases need.A
git archiveexport with export-ignore was tried first and dropped: the publish tool reads the source repo's history and its local publish tag to tell a new release apart from reviewer edits in the monorepo, and a throwaway repo loses both.Verified:
CI=true npm run lint,npm test(89),npm run build, andnpx tsc --noEmitinextension/;scripts/e2e-protocol.mtspasses 19 of 19 against the e2e vault; the store copy diffed against the open store PR removes exactly ARCHITECTURE.md, LICENSE, demo-vault, e2e-vault, and scripts.