Repository navigation
Stop publishing the deprecated Obvs.Serialization.MessagePack package - #105
Merged
Merged
Conversation
It's marked deprecated on nuget.org (#79). Remove it from the CI pack step and make the project non-packable. It is still built and tested. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Obvs.Serialization.MessagePack(MsgPack.Cli) is deprecated in code (#79) and now marked deprecated on nuget.org, so stop publishing new versions of it.Changes
Obvs.Serialization.MessagePack-CSharp.<IsPackable>false</IsPackable>, with a comment, so a manual or solution-widedotnet packdoesn't produce it either.The project is still built and tested, so nothing else breaks while it remains in the solution. Removing it from the repository entirely would be a separate decision.
Testing
dotnet pack Obvs.Serialization.MessagePackproduces no package.Obvs.Serialization.MessagePack-CSharpstill packs.No test was written first, because this only changes CI and build configuration.
🤖 Generated with Claude Code