Repository navigation
Fix NetMQ tests failing when run together - #80
Closed
christopherread wants to merge 1 commit into
Closed
christopherread wants to merge 1 commit into
christopherread wants to merge 1 commit into
Conversation
The pub/sub tests shared port 5556 between themselves and overlapped the 5555-5558 range TestServiceBusWithNetMq binds, which xUnit runs in parallel, and no test disposed its publishers, sources or buses. Give each pub/sub test its own port and dispose everything before asserting. Fixes #72 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 25, 2026
christopherread
added a commit
that referenced
this pull request
Oct 25, 2026
Master now runs tests on Microsoft.Testing.Platform (#101), so use --project and --filter-trait. The NetMQ tests no longer clash over ports (#80), so run them too. The broker steps now come before the unit test step, so this branch no longer edits the lines master changed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
christopherread
added a commit
that referenced
this pull request
Oct 25, 2026
Master now runs tests on Microsoft.Testing.Platform (#101), so use --project and --filter-trait. The NetMQ tests no longer clash over ports (#80), so run them too. The broker steps now come before the unit test step, so this branch no longer edits the lines master changed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #72.
Cause
TestPublishSubscribetests both used port 5556, and the third used 5557.TestServiceBusWithNetMq's endpoint on port 5555 binds 5555–5558 (one port per message kind), and xUnit runs the two classes in parallel.Fix
Only test code changes.
Testing
Explicit, so CI doesn't run them yet; Run broker-backed transport tests in CI #74 covers that.🤖 Generated with Claude Code