Repository navigation
Make blocking tests async to clear xUnit1031 warnings - #81
Closed
christopherread wants to merge 1 commit into
Closed
christopherread wants to merge 1 commit into
christopherread wants to merge 1 commit into
Conversation
Tests that waited on publish/send tasks now await them. The "returns with no observers" tests checked .Wait(1); they now assert the returned task is already completed, which is what the buses guarantee. Fixes #73 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 25, 2026
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #73.
Changes
xUnit's analyzers flagged 10 places in
Obvs.Teststhat block on tasks (TestSubjectMessageBus,TestSubjectMessageBusWithScheduler,TestSubjectServiceBus). Each was reported twice, hence the 20 warnings..Wait()are nowasync Taskandawaitinstead. The "blocks until consumed" tests still check the subscriber ran on the calling thread before the firstawait, so they test the same thing..Wait(1). They now assert the returned taskIsCompleted. Both buses return already-finished tasks, so this checks the same promise without blocking.Only test code changes; I didn't write new tests first, because no library behaviour changes.
Testing
Obvs.sln(--no-incremental) gives 0 warnings, 0 errors.🤖 Generated with Claude Code