Combat Hotkeys: add Arceuus thrall summon hotkey - #555
Conversation
Promote the validated Jewelry, Jad Helper, Herbiboar, and Auto Woodcutting fixes from development. Development Build passed for the exact merged branch head.
chsami
left a comment
There was a problem hiding this comment.
Reviewed head 0001c2f.
P1 lifecycle issue: thrallPending is set before dispatch, but cleared only inside the queued action (or the early executor-null check). If another hotkey action occupies the single-thread executor, queue a thrall and disable the plugin: shutdownNow() drops that queued task without running its finally. On re-enable the same plugin instance still has thrallPending=true, so every later thrall press is ignored. Make the pending state belong to an executor/startup generation and clear cancelled/rejected submissions without letting an old task clear a new request; add a queued-thrall -> shutdown -> restart regression.
CombatHotkeysPlugin.version remains 1.1.2 despite the behavior change. Please bump it and target/rebase onto development for the prescribed Hub PR build. The current targeted build hits the older branch's unrelated Farming Contracts Produce.getContractName() error before packaging.
|
Fixed the pending thrall lifecycle with per-request tokens: shutdown/startup invalidate old requests, discarded queued work no longer blocks restart, old completion cannot clear a newer request, and refused/rejected submissions release their token. Bumped CombatHotkeysPlugin to 1.1.3. Synced development with a clean merge and retargeted the PR there. |
chsami
left a comment
There was a problem hiding this comment.
Re-reviewed the request-token lifecycle fix. Queued cancellation, stale queued/running completions, refused/rejected submissions, and action failure are covered by five passing regression tests. Version/base issues are fixed, targeted CombatHotkeysPlugin build passes, and fresh expected CI is green. Replacing my earlier changes-requested review under the current fix-and-green-light instruction.
Summary
Scope
Only CombatHotkeysConfig.java and CombatHotkeysPlugin.java. No jars, logs, user settings or other plugins.
Verification
Local Java compilation succeeded against the installed Microbot 2.6.22 client (Java 17, --release 11). git diff --check passed. Live in-game summoning and repository CI have not yet been verified.