Repository navigation
Release 0.12.0 - #3
Merged
Merged
Conversation
One Approvals window for proposals and pending deletions (numbers, 2FA to confirm in the panel, rejection reasons back to genco's agent, personal mail links for deletions too); CI fails on svelte-check warnings like the local build. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Confirming in Approvals read the current mail setting: switching mail off (the password alone for an admin without 2FA) let a stolen session confirm deletions and approve proposals that had already been mailed. An action now counts as mailed unless it was created with mail off, a proposal when it has mail links. A rejection's reason reaches genco's agent quoted line by line, so it can't read like genco's own system text. New deletions and the start of a confirmed one send the approvals event, other admins see them right away instead of after the minute check. Proposals carry expiresAt like actions instead of the webui assuming 7 days, the list's status and time helpers moved to approvals.svelte.ts, and the mail-off confirm page uses SecondFactor. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version bump for 0.12.0 (server/Cargo.toml, webui package.json).
Please review everything since tag v0.11.0, not only this bump: commit 9612083 (one Approvals window for proposals and pending deletions: GET /approvals, POST /actions/{key}/confirm with password + 2FA, POST /actions/{id}/reject with reason going back to genco's agent via GENCO_CONVERSATION, personal deletion mail links, the proposal panel approve now requiring password + 2FA, the SSE event renamed to approvals, expiry in the minute check) went to main directly before the PR flow was in place for this work, so it has had no PR review. dcb6781 and 8341f4d were already reviewed as #1 and #2.
Tested on gs4 (genco test server): deletion request A9 listed in /approvals, panel confirm refused without 2FA, wrong code refused, confirmed with code (dump to trash, database dropped), A10 rejected with a reason and kept. Not tested live: rejection reason reaching an agent conversation (unit tests only).