Skip to content

fix(patrol): isolate sandboxes and recover graph routines - #77

Merged
merge-loop[bot] merged 5 commits into
mainfrom
cb/purge-mounts
Nov 15, 2026
Merged

merge-loop[bot] merged 5 commits into
mainfrom
cb/purge-mounts

Conversation

@cjber

@cjber cjber commented Nov 15, 2026

Copy link
Copy Markdown
Owner

Patrol runs shared a reset directory and tmux server, so one task could erase or stop another task's sandbox. The wrappers now accept a named cache root, validate its safety marker, and use a private tmux socket. The GitHub fixture returns a valid empty list so worktree scans can complete.

Recover the verified space and history screen routines and their app-map entries. Keep mount-table lookup failures outside permission repair, including after the awaited retry.

Validation: 10 focused purge tests, TypeScript, Biome, shell syntax, missing-root/unmarked-root/symlink-marker refusal, private TUI start/frame/stop, controlled CLI confirmation and apply/rescan. Independent review found no actionable issues. Seven old exploratory transcripts remain untouched; several assertions are obsolete or intentional, and their evidence is recorded on #75.

Closes #76
Refs #75
Refs #69

cjber and others added 5 commits November 13, 2026 16:30
A directory holding a mount point can be renamed into the trash, and a
recursive delete does not stop at the mount, so purging it would delete
what the mounted filesystem holds. purge now reads the kernel's mount
table first and keeps any transaction with a mount below it, listing it
in failed with the mount points in errors. An unreadable mount table is
a failed lookup, so it keeps every transaction.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01UkMWrwzq4BMWuxvwy47UzT
Keep both unreleased entries and preserve the mount-table purge guard.
Include mounts on the transaction root and re-read the mount table after
hooks or permission repair before deleting. Preserve fail-closed errors.
Use marked cache roots and private tmux sockets, refusing unknown paths.
Return valid JSON from the sandbox GitHub stub so fixture worktrees can
be judged. Keep mount-table read failures outside permission repair.
@cjber cjber added the mergepatrol Queue this PR: Mergepatrol rebases, tests and merges it label Nov 15, 2026
@merge-loop

merge-loop Bot commented Nov 15, 2026 •

Copy link
Copy Markdown
Contributor

Merged as aa9cb91.

@merge-loop
merge-loop Bot merged commit aa9cb91 into main Nov 15, 2026
7 checks passed
@merge-loop
merge-loop Bot deleted the cb/purge-mounts branch November 15, 2026 20:40
@merge-loop merge-loop Bot removed the mergepatrol Queue this PR: Mergepatrol rebases, tests and merges it label Nov 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Patrol sandbox tasks share a reset directory and tmux server

1 participant