Repository navigation
fix(patrol): isolate sandboxes and recover graph routines - #77
Merged
Merged
Conversation
A directory holding a mount point can be renamed into the trash, and a recursive delete does not stop at the mount, so purging it would delete what the mounted filesystem holds. purge now reads the kernel's mount table first and keeps any transaction with a mount below it, listing it in failed with the mount points in errors. An unreadable mount table is a failed lookup, so it keeps every transaction. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UkMWrwzq4BMWuxvwy47UzT
Keep both unreleased entries and preserve the mount-table purge guard.
Include mounts on the transaction root and re-read the mount table after hooks or permission repair before deleting. Preserve fail-closed errors.
Use marked cache roots and private tmux sockets, refusing unknown paths. Return valid JSON from the sandbox GitHub stub so fixture worktrees can be judged. Keep mount-table read failures outside permission repair.
This was referenced Nov 15, 2026
Contributor
|
Merged as aa9cb91. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Patrol runs shared a reset directory and tmux server, so one task could erase or stop another task's sandbox. The wrappers now accept a named cache root, validate its safety marker, and use a private tmux socket. The GitHub fixture returns a valid empty list so worktree scans can complete.
Recover the verified space and history screen routines and their app-map entries. Keep mount-table lookup failures outside permission repair, including after the awaited retry.
Validation: 10 focused purge tests, TypeScript, Biome, shell syntax, missing-root/unmarked-root/symlink-marker refusal, private TUI start/frame/stop, controlled CLI confirmation and apply/rescan. Independent review found no actionable issues. Seven old exploratory transcripts remain untouched; several assertions are obsolete or intentional, and their evidence is recorded on #75.
Closes #76
Refs #75
Refs #69