Repository navigation
fix(ledger): preserve persistent agent claim identity - #84
Merged
Merged
Conversation
Deploying keeper with
|
| Latest commit: |
ec2c3ca
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://331ce8cc.keeper-9oy.pages.dev |
| Branch Preview URL: | https://cb-agent-claim-actor.keeper-9oy.pages.dev |
Owner
Author
|
Independent review of ec2c3ca found no actionable issues. The claim scanner disposes by path and does not use actor liveness, so the README explicitly documents claims as stale-disposal declarations and requires an active writer to use a hold. Focused validation: 93 keeper tests pass, targeted Biome CI passes, and the canonical Codex identity uses CODEX_THREAD_ID with CODEX_SESSION_ID compatibility fallback. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Keeper claims made by agent command wrappers recorded the wrapper's transient parent PID, so cleanup logs could not identify the persistent session that made a claim. Claims now prefer the canonical Codex session identity, retain the explicit
KEEPER_ACTORoverride, and fall back to the parent PID for ordinary shells.A claim remains a stale-disposal declaration and is not a lease. Active writers must use
keeper hold PATH --reason R; the existing hold guard prevents cleanup while that hold is live.Closes #83
Validation
bun test src/keeper.test.ts- 93 passbunx biome ci src/ledger.ts src/keeper.test.tssite/index.htmlspecificity warning is outside this change