Skip to content

[Bug] sign breaks on multi-team accounts #262

Description

@skeet70

Report

I'm assuming given the intended use case this isn't common, but I have multiple teams on one account.
sign calls teams() unconditionally which triggers an interaction on a multi-team account and dies in a non-TTY context.

Adding a --team option to sign to pass a team ID (then using it via match where team_id is set right now) fixes non-TTY use.


On the GUI side (store.rs:166/gsa_account.rs:62):

teams_response.teams[0].team_id.clone()

That makes the GUI default to whatever happens to be first, which in my case also would not be great, it'd pick a professional team for signing. I saw you can set/change the team in settings but there's nothing that tells you it made a default decision and you might want/need to check the setting.

Contributor Checks

  • I am willing to attempt to make a pull request to fix this bug

Additional Information

  • Developer mode enabled
  • Using paid developer account
  • I will send an ipa of the app I'm having trouble installing if any
  • I'm willing to provide crash logs or debugging information if needed

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions