Skip to content

Fix creation responses without storage metadata - #8

Open
pallaoro wants to merge 1 commit into
mainfrom
fix/storage-create-returning
Open

pallaoro wants to merge 1 commit into
mainfrom
fix/storage-create-returning

Conversation

@pallaoro

Copy link
Copy Markdown
Member

Creating a customer, product or invoice through the metadata-less STORAGE binding saved the row but returned HTTP 500; adding an invoice line saved it but returned 404. Callers could retry a successful write or fail to navigate to the new record.

Read each generated ID with INSERT … RETURNING id, following the existing journal creation pattern. Keep the line lookup after totals recomputation so the response contains the calculated amounts. No schema or dependency changes.

Validation: six new HTTP regressions fail on the base commit; all 62 tests and the Vite build pass with the fix. Coverage includes concurrent creates returning their own persisted rows, the complete customer/product/draft/line/issue flow, and a locked-period refusal leaving state unchanged. Independent review also passed the create/issue/concurrent-create/locked-period flows in workerd with both a SQLite Durable Object service binding returning only {rows} and D1. No production deployment was performed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant