Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creating a customer, product or invoice through the metadata-less STORAGE binding saved the row but returned HTTP 500; adding an invoice line saved it but returned 404. Callers could retry a successful write or fail to navigate to the new record.
Read each generated ID with
INSERT … RETURNING id, following the existing journal creation pattern. Keep the line lookup after totals recomputation so the response contains the calculated amounts. No schema or dependency changes.Validation: six new HTTP regressions fail on the base commit; all 62 tests and the Vite build pass with the fix. Coverage includes concurrent creates returning their own persisted rows, the complete customer/product/draft/line/issue flow, and a locked-period refusal leaving state unchanged. Independent review also passed the create/issue/concurrent-create/locked-period flows in workerd with both a SQLite Durable Object service binding returning only
{rows}and D1. No production deployment was performed.