Skip to content

refactor(lib): add client-side redaction for feedback text - #587

Draft
djgould wants to merge 1 commit into
mainfrom
devin/feedback-redact
Draft

djgould wants to merge 1 commit into
mainfrom
devin/feedback-redact

Conversation

@djgould

@djgould djgould commented Oct 26, 2026

Copy link
Copy Markdown
Contributor

Prerequisite for #566 (clerk feedback, GROW-1291), split out so the scrubber gets its own review. Nothing calls it yet; empty changeset.

  • redactText / redactAndCap: best-effort scrubbing of keys, tokens, auth headers, URL credentials, secret-named values, home paths and emails; the limits are listed in the module comment and pinned by tests
  • Includes the review fixes from feat(cli): add clerk feedback to report CLI problems to Clerk #566: a second pass between literal \n/\t, %20 and ANSI codes, and chunked value loops so Bun doesn't silently miss values followed by 50k+ characters
  • Known gap: a 60k+ value that alternates with backslashes still misses on Bun

🤖 Generated with Claude Code

Split out of #566. No caller yet; `clerk feedback` uses it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@changeset-bot

changeset-bot Bot commented Oct 26, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 9b90f84

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai

coderabbitai Bot commented Oct 26, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant