Skip to content

fix(mosaic): keep profile actions pending until verification is ready - #10405

Closed
austincalvelage wants to merge 3 commits into
austin/loom-explorationfrom
codex/profile-verification-readiness
Closed

austincalvelage wants to merge 3 commits into
austin/loom-explorationfrom
codex/profile-verification-readiness

Conversation

@austincalvelage

Copy link
Copy Markdown
Member

Description

Keep User Profile buttons and menu actions pending until the next verification screen is ready. Authenticator setup, backup-code generation, and email/phone verification now prepare before opening their dialogs, avoiding an intermediate loading screen. Add passkey shows a spinner while preserving its button label and size.

Email and phone send failures remain retryable without creating duplicate contacts. Email-link preparation exposes an optional onPrepared callback on EmailAddress.startEmailLinkFlow while preserving its existing completion promise and cancellation behavior.

To verify, delay preparation requests and exercise two-step setup, email/phone Add and Verify, and Add passkey. The source action should stay pending until handoff; preparation failures should allow retry.

Checklist

  • pnpm test runs as expected. Targeted Mosaic browser/unit suites and Clerk JS EmailAddress tests passed in the working checkout.
  • pnpm build runs as expected. Mosaic and Clerk JS builds passed; Mosaic typecheck, lint, and scoped formatting checks passed.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@changeset-bot

changeset-bot Bot commented Oct 23, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: fd2dc3f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 24 packages
Name Type
@clerk/clerk-js Patch
@clerk/shared Patch
@clerk/chrome-extension Patch
@clerk/electron Patch
@clerk/expo Patch
@clerk/mosaic Patch
@clerk/swingset Patch
@clerk/astro Patch
@clerk/backend Patch
@clerk/expo-passkeys Patch
@clerk/express Patch
@clerk/fastify Patch
@clerk/hono Patch
@clerk/localizations Patch
@clerk/loom Patch
@clerk/msw Patch
@clerk/nextjs Patch
@clerk/nuxt Patch
@clerk/react-router Patch
@clerk/react Patch
@clerk/tanstack-react-start Patch
@clerk/testing Patch
@clerk/ui Patch
@clerk/vue Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercel Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
clerk-js-sandbox Ready Ready Preview Oct 23, 2026 9:41pm UTC
swingset Error Error Oct 23, 2026 9:41pm UTC

Request Review

@coderabbitai

coderabbitai Bot commented Oct 23, 2026

Copy link
Copy Markdown
Contributor

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

This branch had an error being deployed

1 failed and 1 active deployments
Preview – swingset — fd2dc3f4 Deployed Oct 23, 2026 by vercel[bot]
Preview – clerk-js-sandbox — fd2dc3f4 Deployed Oct 23, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant