Repository navigation
fix(mosaic): keep profile actions pending until verification is ready - #10405
Closed
austincalvelage wants to merge 3 commits into
Closed
austincalvelage wants to merge 3 commits into
austincalvelage wants to merge 3 commits into
Conversation
🦋 Changeset detectedLatest commit: fd2dc3f The changes in this PR will be included in the next version bump. This PR includes changesets to release 24 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Comment |
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Keep User Profile buttons and menu actions pending until the next verification screen is ready. Authenticator setup, backup-code generation, and email/phone verification now prepare before opening their dialogs, avoiding an intermediate loading screen. Add passkey shows a spinner while preserving its button label and size.
Email and phone send failures remain retryable without creating duplicate contacts. Email-link preparation exposes an optional
onPreparedcallback onEmailAddress.startEmailLinkFlowwhile preserving its existing completion promise and cancellation behavior.To verify, delay preparation requests and exercise two-step setup, email/phone Add and Verify, and Add passkey. The source action should stay pending until handoff; preparation failures should allow retry.
Checklist
pnpm testruns as expected. Targeted Mosaic browser/unit suites and Clerk JS EmailAddress tests passed in the working checkout.pnpm buildruns as expected. Mosaic and Clerk JS builds passed; Mosaic typecheck, lint, and scoped formatting checks passed.Type of change