fix(mosaic): preserve field and global reverification errors by austincalvelage · Pull Request #10558 · clerk/javascript

austincalvelage · 2026-10-30T20:31:30Z

Description

Reverification kept only the first attempt error and displayed it under the active input, even when it belonged to another parameter. Preserve every structured error, show matching password and code errors beside their fields, and show global or unrelated errors in a banner.

Keep the existing localization and fallback policy, error clearing, and retry behavior. The new plural converter is internal to Mosaic; existing single-error callers and legacy UI behavior remain unchanged.

Fixes CORE-4129.

Before and after in Chromium with identical mocked API errors.

Case	Before	After
Password: unrelated error
Password: multiple field and global errors
Backup code: multiple field and global errors

Checklist

pnpm test runs as expected.
pnpm build runs as expected.
(If applicable) JSDoc comments have been added or updated for any package exports
(If applicable) Documentation has been updated

Type of change

changeset-bot · 2026-10-30T20:31:34Z

🦋 Changeset detected

Latest commit: 057e9e5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
@clerk/mosaic	Patch
@clerk/swingset	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel · 2026-10-30T20:31:37Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated
clerk-js-sandbox	Ready	Preview	Oct 30, 2026 11:24pm UTC
swingset	Ready	Preview	Oct 30, 2026 11:24pm UTC

coderabbitai · 2026-10-30T20:31:50Z

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

Run configuration

Source mode: Auto
Repository: clerk/javascript
Branch: austin/core-4129-preserve-field-and-global-errors-in-reverification
File: .coderabbit.yaml
Commit: 057e9e5
Layers: Repository YAML (base), Organization UI (inherited)
Review profile: ASSERTIVE
Plan: Team
Run ID: 9d4b2568-0778-469b-a3fc-effdd86fa265

Commits

Reviewing files that changed from the base of the PR and between abf0628 and 057e9e5.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

No actionable comments were generated in the recent review.

Recent review info

Run configuration

Source mode: Auto
Repository: clerk/javascript
Branch: austin/core-4129-preserve-field-and-global-errors-in-reverification
File: .coderabbit.yaml
Commit: 15af82b
Layers: Repository YAML (base), Organization UI (inherited)
Review profile: ASSERTIVE
Plan: Team
Run ID: 8ef62b30-4f26-4bd5-a78d-14852b26a3a0

Commits

Reviewing files that changed from the base of the PR and between 782937a and 15af82b.

Files selected for processing: 1

packages/mosaic/AGENTS.md

Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

clerk/clerk_go (manual)
clerk/dashboard (manual)
clerk/accounts (manual)
clerk/backoffice (manual)
clerk/clerk (manual)
clerk/clerk-docs (manual)
clerk/cloudflare-workers (manual)
clerk/clerk-android (auto-detected)
clerk/clerk-ios (auto-detected)
clerk/cli (auto-detected)

Included review availability: This review used your included allowance. 2 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 6 reviews per hour.

Walkthrough

The change adds toLocalizableErrors to preserve multiple errors. Reverification stores errors as an array and routes errors that match the active factor to its field. Other errors appear in global alert banners. Tests cover error display, clearing, retries, and factor switching. Package guidance and controller documentation describe the error-handling paths.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related PRs

clerk/javascript#10518: Changes the reverification controller’s error conversion and localization path.
clerk/javascript#10458: Changes the localization tree and fallback contract used by the reverification error path.
clerk/javascript#10519: Changes passkey cancellation and failure handling in the same controller.

Suggested reviewers: ephem

Merge Risk: Minimal · previous review 15af8

Reverification errors are preserved and displayed beside matching fields or in global alerts without an established merge-blocking regression.

Pre-merge checks: 4 · 1

Failed checks: 1 warning

Check name	Status	Explanation	Resolution
Docstring Coverage		Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…	Write docstrings for the functions missing them to satisfy the coverage threshold.

Passed checks: 4 passed

Check name	Status	Explanation
Title check		The title clearly and concisely describes the main change: preserving both field and global reverification errors.
Description check		The description directly explains the reverification error-handling change, expected behavior, testing, and related issue.
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 9 functions across 11 files. (1 skipped: 1 unsupported.)

Resolution

Write docstrings for the functions missing them to satisfy the coverage threshold.

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Linked repositories: Some configured repositories could not be included in this review. Cross-repository analysis may be incomplete. Please check linked-repository access and settings.

_{Comment @coderabbitai help to get the list of available commands.}

pkg-pr-new · 2026-10-30T20:56:58Z

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@10558

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@10558

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@10558

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@10558

@clerk/electron

npm i https://pkg.pr.new/@clerk/electron@10558

@clerk/electron-passkeys

npm i https://pkg.pr.new/@clerk/electron-passkeys@10558

@clerk/eslint-plugin

npm i https://pkg.pr.new/@clerk/eslint-plugin@10558

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@10558

@clerk/expo-biometrics

npm i https://pkg.pr.new/@clerk/expo-biometrics@10558

@clerk/expo-google-signin

npm i https://pkg.pr.new/@clerk/expo-google-signin@10558

@clerk/expo-native-components

npm i https://pkg.pr.new/@clerk/expo-native-components@10558

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@10558

@clerk/express

npm i https://pkg.pr.new/@clerk/express@10558

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@10558

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@10558

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@10558

@clerk/mosaic

npm i https://pkg.pr.new/@clerk/mosaic@10558

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@10558

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@10558

@clerk/react

npm i https://pkg.pr.new/@clerk/react@10558

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@10558

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@10558

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@10558

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@10558

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@10558

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@10558

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@10558

commit: 057e9e5

vercel Bot deployed to Preview – clerk-js-sandbox October 30, 2026 20:31

View deployment

vercel Bot deployed to Preview – swingset October 30, 2026 20:35

View deployment

austincalvelage force-pushed the austin/core-4129-preserve-field-and-global-errors-in-reverification branch from b792ea2 to 782937a Compare October 30, 2026 20:53

github-actions Bot added the mosaic label Oct 30, 2026

vercel Bot deployed to Preview – clerk-js-sandbox October 30, 2026 20:54

View deployment

austincalvelage requested a review from alexcarpenter October 30, 2026 20:54

vercel Bot deployed to Preview – swingset October 30, 2026 20:56

View deployment

vercel Bot deployed to Preview – clerk-js-sandbox October 30, 2026 21:00

View deployment

vercel Bot deployed to Preview – swingset October 30, 2026 21:01

View deployment

austincalvelage force-pushed the austin/core-4129-preserve-field-and-global-errors-in-reverification branch from 15af82b to abf0628 Compare October 30, 2026 22:52

vercel Bot deployed to Preview – clerk-js-sandbox October 30, 2026 22:53

View deployment

vercel Bot deployed to Preview – swingset October 30, 2026 22:55

View deployment

austincalvelage added 2 commits October 30, 2026 17:20

fix(mosaic): preserve field and global reverification errors

0e52d71

chore(mosaic): format contributor guide table

057e9e5

austincalvelage force-pushed the austin/core-4129-preserve-field-and-global-errors-in-reverification branch from abf0628 to 057e9e5 Compare October 30, 2026 23:20

vercel Bot deployed to Preview – clerk-js-sandbox October 30, 2026 23:21

View deployment

vercel Bot deployed to Preview – swingset October 30, 2026 23:24

View deployment

Navigation Menu

Repository navigation

fix(mosaic): preserve field and global reverification errors - #10558

fix(mosaic): preserve field and global reverification errors#10558
austincalvelage wants to merge 2 commits into
mainfrom
austin/core-4129-preserve-field-and-global-errors-in-reverification

austincalvelage commented Oct 30, 2026 •

edited

Loading

Uh oh!

changeset-bot Bot commented Oct 30, 2026 •

edited

Loading

Uh oh!

vercel Bot commented Oct 30, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Oct 30, 2026 •

edited

Loading

Review skipped

Uh oh!

pkg-pr-new Bot commented Oct 30, 2026 •

edited

Loading

Uh oh!

This branch was successfully deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

austincalvelage commented Oct 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Type of change

Uh oh!

changeset-bot Bot commented Oct 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

vercel Bot commented Oct 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot commented Oct 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

pkg-pr-new Bot commented Oct 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This branch was successfully deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

austincalvelage commented Oct 30, 2026 •

edited

Loading

changeset-bot Bot commented Oct 30, 2026 •

edited

Loading

vercel Bot commented Oct 30, 2026 •

edited

Loading

coderabbitai Bot commented Oct 30, 2026 •

edited

Loading

pkg-pr-new Bot commented Oct 30, 2026 •

edited

Loading