You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
test(mosaic): update visual baselines for the border and media size changes - #10668
Updates the six Mosaic screenshot baselines that every PR has been reporting as different (organization-switcher, user-button, and four user-profile states).
The baselines landed in #10451. #10496 (control and container borders, state washes) and #10600 (shared media sizes and radii) merged afterwards from branches cut before #10451, so the visual tests never ran on them. The visual job only warns on differences, so both PRs merged with green checks.
These changes from those PRs account for the differences:
Containers moved to the subtle border (feat(mosaic): split control and container borders and use washes for states #10496). Data lists and their row dividers, items, card footers, menu separators, avatars, icon frames, and profile and section dividers switched from --cl-color-border to --cl-color-border-subtle. Their outlines went from 7% to 8% in light mode and from 12% to 8% in dark mode, which is why the dark screenshot has the most differing pixels.
clerk/javascript#10496: Changes Mosaic styling that appears in the updated screenshot baselines.
clerk/javascript#10665: Updates Mosaic item-row styling covered by the same screenshot tests.
Merge Risk: Minimal · up to dde52
The baseline-only change has no release or runtime risk requiring resolution before merge.
Pre-merge checks: 4
Check name
Status
Explanation
Title check
The title names the change: updating visual test baselines for the border and media size changes. The changeset is a test-baseline update for six Mosaic screenshots, and the description ties those upd…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Description check
The description states that it updates six Mosaic screenshot baselines (organization-switcher, user-button, and four user-profile states) and explains which earlier changes (border tokens, container b…
Full details: Title check
Explanation
The title names the change: updating visual test baselines for the border and media size changes. The changeset is a test-baseline update for six Mosaic screenshots, and the description ties those updates to the border and media-size changes from #10496 and #10600. The title is specific enough for a teammate scanning history.
Full details: Description check
Explanation
The description states that it updates six Mosaic screenshot baselines (organization-switcher, user-button, and four user-profile states) and explains which earlier changes (border tokens, container border moves, control outlines, neutral badge fill, avatar size) cause the visual differences. This directly matches the changeset's test-baseline content, so the description is clearly related to the changes. Note that the raw summary describes the changeset as only a Changesets entry with empty front matter, which does not show the baseline images or token changes; the description's subject matter is still in scope for the PR objectives, which also describe the six baseline updates.
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Warning
Linked repositories: Some configured repositories could not be included in this review. Cross-repository analysis may be incomplete. Please check linked-repository access and settings.
Reviewing files that changed from the base of the PR and between 5b12ac8 and dde527d.
Files ignored due to path filters: 6
packages/mosaic/src/features/organization-switcher/__tests__/__screenshots__/organization-switcher.visual.test.tsx/organization-switcher-open-chromium-linux.png is excluded by !**/*.png
packages/mosaic/src/features/user-button/__tests__/__screenshots__/user-button.visual.test.tsx/user-button-combined-open-chromium-linux.png is excluded by !**/*.png
packages/mosaic/src/features/user-profile/__tests__/__screenshots__/user-profile.visual.test.tsx/user-profile-account-desktop-dark-chromium-linux.png is excluded by !**/*.png
packages/mosaic/src/features/user-profile/__tests__/__screenshots__/user-profile.visual.test.tsx/user-profile-account-desktop-light-chromium-linux.png is excluded by !**/*.png
packages/mosaic/src/features/user-profile/__tests__/__screenshots__/user-profile.visual.test.tsx/user-profile-account-narrow-light-chromium-linux.png is excluded by !**/*.png
packages/mosaic/src/features/user-profile/__tests__/__screenshots__/user-profile.visual.test.tsx/user-profile-edit-name-error-chromium-linux.png is excluded by !**/*.png
Files selected for processing: 1
.changeset/mosaic-visual-baselines.md
Linked repositories identified
CodeRabbit considers these linked repositories for cross-repo context during reviews:
Included review availability: This review used your included allowance. 4 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates the six Mosaic screenshot baselines that every PR has been reporting as different (organization-switcher, user-button, and four user-profile states).
The baselines landed in #10451. #10496 (control and container borders, state washes) and #10600 (shared media sizes and radii) merged afterwards from branches cut before #10451, so the visual tests never ran on them. The visual job only warns on differences, so both PRs merged with green checks.
These changes from those PRs account for the differences:
tokens.stylex.ts).--cl-color-borderchanged from 7% neutral to--cl-color-neutral-alpha-300(12%) in light mode, and--cl-color-border-subtlefrom 4% to--cl-color-neutral-alpha-200(8%). Dark mode values didn't change.--cl-color-borderto--cl-color-border-subtle. Their outlines went from 7% to 8% in light mode and from 12% to 8% in dark mode, which is why the dark screenshot has the most differing pixels.--cl-color-border, so their light-mode outlines went from 7% to 12%. Outline buttons also changed from a transparent fill to--cl-color-surface.badge.styles.ts). The "Primary" badge's fill changed from--cl-color-neutral-alpha-100to--cl-color-neutral-subtle, which is 6% to 8% in light mode.media-size.styles.ts). Themdavatar grew fromspace['9.5']tospace['10'](38px to 40px), which shifts the organization-switcher header text 2px to the right.The new baselines are byte-identical to the screenshots CI rendered on current main. No other baselines changed.
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change